Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Publish button is clickable #13014

Closed
mmtr opened this issue Dec 19, 2018 · 1 comment
Closed

Disabled Publish button is clickable #13014

mmtr opened this issue Dec 19, 2018 · 1 comment
Labels
[Package] Editor /packages/editor [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@mmtr
Copy link
Contributor

mmtr commented Dec 19, 2018

Describe the bug
As of #11543, PostPublishButton doesn't have a disabled attribute anymore, but uses aria-disabled instead. This is allowing to click on the button, when it shouldn't be possible (for example when the post content is empty).

To Reproduce

  1. Start creating a new post
  2. Note how the "Publish..." button is styled as disabled
  3. Click on the "Publish..." button

Expected behavior
The Pre-publish checks sidebar shouldn't be opened since the Publish button is disabled. Furthermore, the "Publish" button displayed there is also disabled, but we can still click on it a save the post (note how the date change from "Immediately" to the current date).

Screenshots
image

Additional context
Issue found on Automattic/wp-calypso#29594 (props to @Copons).

@mmtr mmtr added the [Package] Editor /packages/editor label Dec 19, 2018
@swissspidy swissspidy added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Dec 19, 2018
@swissspidy
Copy link
Member

Duplicate of #11809. PR: #11760.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants