-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky Notices overlap Classic Editor toolbar on scroll #14402
Comments
Noting that this is not specific to the classic block, it's the same for all blocks. Pushing down the toolbar is not possible because these are rendered in very different contexts. Not sure what we can do here. We can play with "z-index" but I feel what we have now is a fine compromise. Thoughts @jasmussen |
Thanks @youknowriad I had another thought on this last night. I wonder if the dismissable sticky notifs can have two action icons. The close that's there but a minimize as well that's beside the close. When minimized it slides to the left leaving just a tab in the notice colour. Hover on the tab and it displays some of it and clicking expands again so you can then read or dismiss it. Thoughts? |
I agree that these notices need to be improved. I think if we take a look at the kind of notices we have, we can distinguish two:
I think there might be another issue talking about this kind of improvements, if we find the issue, we should close this one as a duplicate. |
Nice, those snackbars are yummy. And the bottom positioning I feel will work better to avoid interfering with block toolbars and editing in general. |
Looks like I found the issue #13905 let's consolidate there. |
Describe the bug
When editing a page with long content in the Classic Block the classic editor toolbar becomes sticky and follows you down the block. When you have sticky notices they overlap this toolbar on scroll requiring you to dismiss the notices to be able to edit.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Not quite sure the best approach here but possibly have the toolbar pushed down below the notices so it becomes available. Or while the block is in focus being edited place it at a higher z-index than the notices so it becomes fully editable.
Screenshots
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: