Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacer NaN warning #14426

Closed
gregbia opened this issue Mar 14, 2019 · 3 comments · Fixed by #14785
Closed

Spacer NaN warning #14426

gregbia opened this issue Mar 14, 2019 · 3 comments · Fixed by #14785
Labels
[Block] Spacer Affects the Spacer Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@gregbia
Copy link

gregbia commented Mar 14, 2019 •
edited
Loading

If clearing the number input for the spacer block, we get a "NaN" is not a valid number console error. On save and refresh a block validation failed message shows.

image

image

Version: WP 5.1
@kelin1003
Copy link
Contributor

I see this happening in my local env as well, I'd like to take this issue if possible.
How do we want to proceed? Do we want some minimum height for spacer or 0 is fine?

@swissspidy swissspidy added the [Block] Spacer Affects the Spacer Block label Mar 14, 2019
@swissspidy
Copy link
Member

A spacer with height 0 might be impossible to select/click on, so a sensible default might make sense. Needs testing though.

@swissspidy swissspidy added the [Type] Bug An existing feature does not function as intended label Mar 14, 2019
@kelin1003
Copy link
Contributor

Yes with height 0 the spacer can't be selected unless using tabs or arrows.
Currently we have minimum value set at 20 for the input box.

@jorgefilipecosta jorgefilipecosta self-assigned this Mar 15, 2019
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Apr 2, 2019
@Jackie6 Jackie6 mentioned this issue Apr 3, 2019
Merged
2 tasks
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
@talldan talldan removed the [Status] In Progress Tracking issues with work in progress label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Spacer Affects the Spacer Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spacer NaN warning Jackie6/gutenberg
6 participants
@talldan @gziolo @swissspidy @jorgefilipecosta @kelin1003 @gregbia