Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve End to End testing docs and add more CLI args #14494

Closed
gziolo opened this issue Mar 18, 2019 · 1 comment
Closed

Improve End to End testing docs and add more CLI args #14494

gziolo opened this issue Mar 18, 2019 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Developer Documentation Documentation for developers

Comments

@gziolo
Copy link
Member

gziolo commented Mar 18, 2019

@draganescu added some new CLI arguments to wp-scripts test-e2e command in #14129.
We forgot to document them inside @wordpress/scripts package and update the existing End to End testing docs:
https://github.com/WordPress/gutenberg/blob/master/docs/contributors/testing-overview.md#end-to-end-testing.

We could also extend CLI arguments with a few more to simplify the following command:

WP_BASE_URL=http://localhost:8888 WP_USERNAME=admin WP_PASSWORD=password npm run test-e2e
@gziolo gziolo added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Developer Documentation Documentation for developers Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Mar 18, 2019
This was referenced Mar 18, 2019
Closed
Closed
This was referenced Mar 28, 2019
Closed
Merged
@gziolo
Copy link
Member Author

gziolo commented Apr 1, 2019

Fixed with #14717.

@gziolo gziolo closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gziolo