Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block gallery: deselect first/last image #14823

Closed
oandregal opened this issue Apr 4, 2019 · 4 comments · Fixed by #14930
Closed

Block gallery: deselect first/last image #14823

oandregal opened this issue Apr 4, 2019 · 4 comments · Fixed by #14930
Assignees
@oandregal
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@oandregal
Copy link
Member

oandregal commented Apr 4, 2019 •
edited
Loading

When tabbing through the image galleries, the images at the edges (first/last) don't get deselected when focus changes to the toolbar (it tabbing backward from first image) or the media buttons (if tabbing forward from last image):

Peek 2019-04-04 17-20
@oandregal oandregal self-assigned this Apr 4, 2019
@oandregal oandregal added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended labels Apr 4, 2019
@mkaz mkaz mentioned this issue Apr 4, 2019
Closed
@oandregal oandregal changed the title Block gallery: unselect first/last image Block gallery: deselect first/last image Apr 4, 2019
This was referenced Apr 5, 2019
Closed
Merged
@oandregal
Copy link
Member Author

#14930 fixes this.

@oandregal oandregal added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Apr 12, 2019
@oandregal oandregal mentioned this issue May 9, 2019
Merged
@talldan
Copy link
Contributor

talldan commented Feb 7, 2020

@nosolosw as you might be able to tell, I'm looking through a few past gallery issues!

This one doesn't seem to be an issue any more in my testing. The keyboard navigation has changed quite a bit in the editor, so I think that may have resolved things. Having said that, I noticed you have an open PR that was recently rebased. Can you reproduce this in master?

@talldan
Copy link
Contributor

talldan commented Feb 7, 2020

Oh wait, I completely misread this issue 🤦‍♂

Ignore my comment above..

@oandregal
Copy link
Member Author

@talldan any change you could help get #14930 reviewed? It's been a bit difficult to give it the attention it deserves :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Gallery: deselect first/last image on blur WordPress/gutenberg
2 participants
@oandregal @talldan