Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange behaviour when resizing (images, spacers, etc) #15420

Closed
vonloxx opened this issue May 3, 2019 · 2 comments · Fixed by #17175
Closed

Strange behaviour when resizing (images, spacers, etc) #15420

vonloxx opened this issue May 3, 2019 · 2 comments · Fixed by #17175
Labels
[Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block [Block] Spacer Affects the Spacer Block [Feature] Media Anything that impacts the experience of managing media [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@vonloxx
Copy link
Contributor

vonloxx commented May 3, 2019

Describe the bug
When resizing, for example, an image, the resize drag handlers disappear and only appear again when deselecting the block and selecting again. This also happens on spacer and media text blocks. Tested with Gutenberg 5.6.1 and Gutenberg Playground (also Drupal Gutenberg - latest dev 😉).

To reproduce
Steps to reproduce the behavior:

  1. Add an image block
  2. Resize using the resizer drag handler

Screenshots
resizer-issue-1

Desktop (please complete the following information):

  • OS: macOS
  • Browser Chrome
  • Version [e.g. 22]

Additional context

  • Gutenberg 5.6.1
@swissspidy swissspidy added [Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block [Block] Spacer Affects the Spacer Block [Feature] Media Anything that impacts the experience of managing media labels May 4, 2019
@vonloxx
Copy link
Contributor Author

vonloxx commented May 6, 2019 •
edited
Loading

At a first glance, it seems the block loses its .is-focused / .is-selected class when clicking on the resizer handler.

@thorandre
Copy link

Confirming this issue. But the issue is more problematic with the "Media & Text" block, than with "Image".
Also reported for Drupal Gutenberg here:
https://www.drupal.org/project/gutenberg/issues/3029680

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Aug 23, 2019
This was referenced Aug 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Block] Media & Text Affects the Media & Text Block [Block] Spacer Affects the Spacer Block [Feature] Media Anything that impacts the experience of managing media [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix image flickering & focus lose on resizing WordPress/gutenberg
4 participants
@youknowriad @thorandre @swissspidy @vonloxx