Images: Adding images to a post doesn't also attach it

[jasmussen]

This can cause theme issues.

[aduth]

Should be fixed as of #1967

[rachelmcr]

I tested publishing a photo post in Gutenberg 1.4.0 and the photo wasn't attached. Video of my publishing flow and other details here: https://test.wordpress.com/2017/10/13/image-posting-flow-gutenberg/

[aduth]

To clarify, this appears to be specific to drag-and-drop upload, which uses its own implementation to upload to the WordPress REST API. Uploading using the media library within Gutenberg will correctly attach the image to the post.

[aduth]

The naive answer would be to inject _wpMediaViewsL10n.settings.post.id as parent property in the media upload:

gutenberg/utils/mediaupload.js

Lines 74 to 77 in 2328828

	return new wp.api.models.Media().save( null, {
	data: data,
	contentType: false,
	} );

But...

• Something is clobbering ``_wpMediaViewsL10n.settings` at runtime and it isn't accessible after page loda
• This ties the media upload tool to the presence of a window global, and is less predictable by its implicitness (not pure). Ideally that which calls the upload would also pass the post ID as an argument.

For drag-and-drop, that happens in the image block transform:

gutenberg/blocks/library/image/index.js

Lines 69 to 81 in 2328828

	{
	type: 'files',
	isMatch( files ) {
	return files.length === 1 && files[ 0 ].type.indexOf( 'image/' ) === 0;
	},
	transform( files ) {
	return createMediaFromFile( files[ 0 ] )
	.then( ( media ) => createBlock( 'core/image', {
	id: media.id,
	url: media.source_url,
	} ) );
	},
	},

This ties into #2473, where blocks (let alone transforms) don't currently have easy access to post state.

[mrleemon]

Is the "Attached to this post" idea going to be deprecated with Gutenberg? I'm asking this because some custom post types I've seen out there (Portfolio, Events, Ads, etc...) use this to just display images attached to posts.

[bobbingwide]

Please can someone give this bug the attention it deserves? It's a backward compatibility issue.

[bobbingwide]

I’d just like to point out that this problem occurs when using the Upload button in the Image block.

[danielbachhuber]

@joemcgill Did you get anywhere on this or can I help out with it?

[joemcgill]

@danielbachhuber haven’t looked at it yet. Was hoping to have a go at it soon, but feel free.