Add button text and close prop to MediaUpload

[afercia]

Describe the bug
In WordPress core, it's possible to invoke a Media modal with wp.media() and pass a couple properties to the modal "Select" button, ie: the button in the bottom right:

• text: a custom text for the button
• close: whether the modal should close when clicking the button

In the Gutenberg MediaUpload it is possible to pass only the Modal title, see:

gutenberg/packages/media-utils/src/components/media-upload/index.js

Lines 78 to 107 in bd76217

	class MediaUpload extends Component {
	constructor( {
	allowedTypes,
	gallery = false,
	modalClass,
	multiple = false,
	title = __( 'Select or Upload Media' ),
	} ) {
	super( ...arguments );
	this.openModal = this.openModal.bind( this );
	this.onOpen = this.onOpen.bind( this );
	this.onSelect = this.onSelect.bind( this );
	this.onUpdate = this.onUpdate.bind( this );
	this.onClose = this.onClose.bind( this );
	if ( gallery ) {
	this.buildAndSetGalleryFrame();
	} else {
	const frameConfig = {
	title,
	button: {
	text: __( 'Select' ),
	},
	multiple,
	};
	if ( !! allowedTypes ) {
	frameConfig.library = { type: allowedTypes };
	}
	this.frame = wp.media( frameConfig );

1
passing a button text prop seems pretty simple to me and would allow parity with the current usage, when plugins or other core workflows need a better button text.

2
in core, the close prop is set to false when it is necessary to not close the modal and switch to another state/view, for example when the following step is the image cropping (see legacy custom header, custom background pages, and in the Customizer).

I'm not sure if in Gutenberg there is already a way to not close the modal (couldn't find it). If there's none, I'd tend to think it is necessary to implement a similar feature to allow for custom workflows.

Note: MediaUpload has just been extracted to its own package in #15521 /Cc @jorgefilipecosta

[paaljoachim]

Is this issue still relevant?

@joedolson
Joe I am pinging you to older issues that Andrea created (as you probably have noticed).

[joedolson]

Looks to me like nothing has changed here; the issue is still relevant.