Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Cap applies to punctuation #1622

Closed
aaronjorbin opened this issue Jun 30, 2017 · 4 comments
Closed

Drop Cap applies to punctuation #1622

aaronjorbin opened this issue Jun 30, 2017 · 4 comments
Labels
Needs Design Feedback Needs general design feedback.

Comments

@aaronjorbin
Copy link
Member

aaronjorbin commented Jun 30, 2017

If the text starts with a since letter and a punctuation mark (such as the word "I've"), then both the letter and the punctuation mark appear bigly.

@westonruter
Copy link
Member

This seems to be due to ::first-letter is being used, and according to MDN:

The first letter of an element is not always trivial to identify: ¶ Punctuation that precedes or immediately follows the first letter is included in the match. Punctuation includes any Unicode character defined in the open (Ps), close (Pe), initial quote (Pi), final quote (Pf), and other punctuation (Po) classes.

The solution may involve #1340 in which the PHP render callback can wrap the actual first letter with a span which can then be styled without using ::first-letter.

@mtias
Copy link
Member

mtias commented Aug 18, 2017

Sounds like the alternative of just making the I bigger but keep the ' as the first item of the small line wouldn't be a great typographic experience either. Since this is opt-in, I think we should just consider it a tradeoff.

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Nov 20, 2017
@jasmussen
Copy link
Contributor

I'm going to close this one as, while I agree with the sentiment of the ticket — it would be nice with smarts here — there isn't really anything we can do. Since it's an advanced feature, off by default, and actively toggled presumably through intent, an argument can be made that this is both expected behavior and a "feature". In other words if we were able to make some smarts here, then the opposite argument could be made — drop cap doesn't work for punctuation. Who knows what crazy poetry someone might want to write.

@JJJ
Copy link
Contributor

JJJ commented Nov 24, 2018

I do not expect for an apostrophe to be part of the drop-cap. It looks really weird, and feels like a bug.

screen shot 2018-11-23 at 11 30 28 pm

screen shot 2018-11-23 at 11 32 16 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

5 participants