Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a name to group blocks to be shown in block navigation #16296

Closed
Tracked by #29733
lucspe opened this issue Jun 26, 2019 · 16 comments
Closed
Tracked by #29733

Adding a name to group blocks to be shown in block navigation #16296

lucspe opened this issue Jun 26, 2019 · 16 comments
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Block API API that allows to express the block paradigm. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.

Comments

@lucspe
Copy link

lucspe commented Jun 26, 2019

Hi,

Whilst testing the recently introduced "group" block, I find a bit frustrating that there is no way to assign a name to each of them to make it easier to go through the document using the block navigation.

Currently, each "group" block will appear in block navigation simply as "Group" as per screenshot

screenshot_what_i_see

It would be great if there was a way to assign some kind of name to be able to identify what each of those groups are, as per screenshot

screenshot_what_i_would_like_to_see

This is particularly frustrating when dealing with long posts or pages.

Beyond this particular block, in my opinion there are other blocks that could benefit from having the possibility of having a name assigned in the block navigation (such as images, videos, etc.) to make the block navigation a more effective tool.

@karmatosed, we discussed this briefly at WCEU and you suggested that I write it in GitHub. I hope the format is correct and the matter is clear.

Thank you

@swissspidy swissspidy added [Block] Group Affects the Group Block (and row, stack and grid variants) [Type] Enhancement A suggestion for improvement. labels Jun 26, 2019
@swissspidy
Copy link
Member

Reusable blocks already have names, maybe we can use the same component for that.

@karmatosed
Copy link
Member

I think being able to add a name to a group block could be a really useful functionality. Thanks for suggesting this @lucspe.

@karmatosed karmatosed added the Needs Design Needs design efforts. label Jun 26, 2019
@mtias
Copy link
Member

mtias commented Jun 26, 2019

It might also be interesting to expose the ID attribute if it's set for a block (group does support a specific anchor).

image

@karmatosed karmatosed self-assigned this Jun 26, 2019
@karmatosed
Copy link
Member

karmatosed commented Jun 27, 2019

What we have now for reusable blocks is this:

reusable-blocks

I took a little exploration into maybe how we could take a slightly different approach:

alternative-editing

This gives us both options and maybe even something to explore with reusable blocks. Noting the 'edit' or 'save' and even name only appears on interacting with the block.

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels Jun 27, 2019
@richtabor
Copy link
Member

I took a little exploration into maybe how we could take a slightly different approach:

Definitely interesting and I like the idea. Thinking aloud here, but a few thought questions:

Do you think this is important enough to be in the toolbar? Perhaps considering a control in the Sidebar Settings would be more appropriate. And should users be encouraged to add a name to a Group block? Or is it a specialty case?

I'm wondering how this plays with the context of other blocks. For example, should any block be namable? What's the user's expectation on that front?

@karmatosed
Copy link
Member

Do you think this is important enough to be in the toolbar? Perhaps considering a control in the Sidebar Settings would be more appropriate. And should users be encouraged to add a name to a Group block? Or is it a specialty case?

A good point. I went with that location to build on the position of the nested blocks. I wouldn't at all be opposed to explorations there also for nested blocks.

I'm wondering how this plays with the context of other blocks. For example, should any block be namable? What's the user's expectation on that front?

I think as these have default names or 'group' 'nested', then naming unique names makes sense. However, it does make me wonder what the use case would be for naming anything and if that's something to explore. Thanks for making me think!

@mtias
Copy link
Member

mtias commented Jul 14, 2019

Let's definitely try this first in the "advanced" panel in the block inspector.

@karmatosed
Copy link
Member

@mtias here is a quick mock-up to see if what you are thinking about:

group

I actually quite like that as an option, but only if we also change reusable blocks to use that.

@karmatosed karmatosed removed their assignment Jul 17, 2019
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 17, 2019
@mtias
Copy link
Member

mtias commented Jul 24, 2019

I actually quite like that as an option, but only if we also change reusable blocks to use that.

It's more important for reusable blocks to have a name than it is for group blocks. For reusable blocks it is a primary action, for blocks it's just an advanced setting for certain circumstances.

@lucspe
Copy link
Author

lucspe commented Aug 8, 2019

I think as these have default names or 'group' 'nested', then naming unique names makes sense. However, it does make me wonder what the use case would be for naming anything and if that's something to explore. Thanks for making me think!

@karmatosed & @mtias, let me share some details about why this request came up, maybe it is useful for you.
We are working on a project where we are converting an existing website that is currently using a different visual builder to use Gutenberg instead.
The marketing team builds rather complex pages, the classic examples being landing pages, and the group block turned out to be extremely useful in this regard.
Their feedback was that using the block navigation it was not immediate to grasp what each group contained so they asked if it was possible to assign descriptive names to them (examples given were: "intro text", "main call to action", etc.).
Based on your doubt whether there would be a "use case for naming anything" I discussed it with them and it turned out that the other block where they saw a use for it (although it was "not so important as for groups" in their own words) was the blocks that added multimedia content (youtube videos etc.).
I hope this helps.

@kyle-charlton
Copy link

Are there any further discussions on implementing this feature?
The development team I work with make heavy use of groups, columns and Media & Text blocks on many of our custom pages and having the ability to name any type of "Parent block" would be a welcome navigation improvement.

We generally try to organize our pages by break up different sections of a page into its own groupings, so a page with say 5 sections (header, content, unique design elements) would have 5 groups created.

Seeing a list like the image below could be more useful with custom names for navigating.

image

I also like the idea of having the name field appear in the "advanced" panel in the block inspector

@mtias here is a quick mock-up to see if what you are thinking about:

group

I actually quite like that as an option, but only if we also change reusable blocks to use that.

@djbakedpotato
Copy link

I too would like to see this feature

in the meantime we are using this plugin:

https://wordpress.org/plugins/block-navigation/

image

@talldan talldan added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label May 27, 2020
@mtias mtias added the [Feature] Block API API that allows to express the block paradigm. label Jun 8, 2020
@sophiegyo
Copy link

sophiegyo commented Apr 28, 2021

I am glad I found this feature request already open as I was about to open a similar one, I'd definitely be interesed in being able to name blocks - either by showing the id/anchor or with a separate name field. I was also thinking of suggesting the name field in the Advanced section, it's a great-to-have, not a must in my opinion. Reusable blocks already show their names/post titles (since they're a post type) in the list view, and I think it could be handy for managing pages with lots of parent blocks that have content nested in them.

@justintadlock
Copy link
Contributor

justintadlock commented May 16, 2021

Just came by to say I was looking for this too. I tend to use the breadcrumbs for navigation, and find it pretty much impossible to figure out which group I'm looking for in a theme I'm working on. Example:

... > Group > Group > Template Part Name > Group > Group > Group

At the very least, adding the tagName argument would help. Like Group <header>, Group <footer>, and so on. Named would be better though.

@mtias
Copy link
Member

mtias commented May 17, 2021

Related #16307

@talldan
Copy link
Contributor

talldan commented Apr 4, 2023

I'm going to close this one out as a superseded by #33583

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block (and row, stack and grid variants) [Feature] Block API API that allows to express the block paradigm. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

10 participants