Uncaught PHP exceptions in do_blocks()

[ocean90]

Gutenberg_PEG_Parser::parse() can throw an exception which is not caught by an error handler in do_blocks() leading to a fatal error.

[nylen]

Which exception is this? With what content does it occur?

[swissspidy]

There's a throw new Exception("Can't start parsing from rule \"" + $options["startRule"] + "\"."); line in that method.

[ocean90]

Right, there's also throw $this->peg_buildException(), a wrapper for Gutenberg_PEG_SyntaxError.

[nylen]

Neither of these are reachable in our setup. Feel free to reopen this if there is a unit-testable case here but I am pretty sure there isn't.

[ocean90]

Looks like the current parser isn't the best solution anyway so I'm fine with closing.

[nylen]

That's a separate discussion. I closed this because I don't think it's a practical problem. If that's not right, please let me know and we'll fix it.