Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format of the pattern library #1706

Closed
karmatosed opened this issue Jul 4, 2017 · 5 comments
Closed

Format of the pattern library #1706

karmatosed opened this issue Jul 4, 2017 · 5 comments

Comments

@karmatosed
Copy link
Member

We have an issue for what it will contain. This issue is to work out the format. Will it be based on Gutenberg? Will it use other methods such as:

Are there other ways to do this?

We want to have this is easy to do as possible, how can that happen? Should it be automated or will that come later?

@karmatosed
Copy link
Member Author

karmatosed commented Jul 4, 2017

My own feelings on this are:

  • Start documenting even in simple install using sketch file as basis
  • Bring in more complex methods as time develops

If a fully automated way can happen, that would be great, but until then I think taking an example from https://wpcalypso.wordpress.com/devdocs/design and doing similar. At least this gets the ball rolling. What do others think? I will let some discussion happen here but looking to begin next week.

@aduth
Copy link
Member

aduth commented Jul 18, 2017

Some similar efforts:

(cc @withinboredom)

Some of the format depends on what we want to show: If it's simple pre-programmed demonstrations, we don't really need anything automatic, just a separate component that renders the example. See also: example.jsx pattern in Calypso. The only issue here is that any adjustable values need to be manually implemented, which is not too bad, but could benefit from automation. Similarly, Calypso's DevDocs lack any code snippets or prop documentation.

Storybook has some nice solutions here:

The work in #1786 kept some of these requirements in mind, which influenced it being implemented as a React application, since this will simplify embedding components for a pattern library.

@withinboredom
Copy link

I've worked with StoryBook with knobs in the past, and it forces you to make your components as prop-driven as possible and ignore state. I really liked it, personally.

The nice thing about it, is that it allows you to demo a component for someone and test it out while developing it. IOW, you can focus a little more on ux from the beginning instead of worrying about integrating it into the application to get it to compile, run, etc. I felt like it lowered the barrier to entry tremendously, because a junior dev could build something awesome and show it to us, without having to have a depth of knowledge about the application framework and state management. After they were done with the feature, they could grab someone and get help actually integrating the component itself (or someone could even do it for them).

My 2¢ about it, anyway.

@karmatosed
Copy link
Member Author

I really like idea we explore as much automation on this as possible. Which ever way that goes. Would it be worth spending some time in the weekly meeting talking through this?

@karmatosed
Copy link
Member Author

Closing as moving to the project. We are moving things to projects that aren't core Gutenberg and need to be done apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants