Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block inserter doesn't show that some blocks are disabled #17235

Open
brentswisher opened this issue Aug 28, 2019 · 4 comments
Open

Block inserter doesn't show that some blocks are disabled #17235

brentswisher opened this issue Aug 28, 2019 · 4 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@brentswisher
Copy link
Contributor

Problem
At some point in testing, I disabled the "Core Blocks" in the block manager. A few days later when I came back to work on Gutenberg, I opened up a new post and instead of the normal default paragraph I could tab into, there was just a full-width block inserter:

Add_New_Post_‹Gutenberg_Dev—_WordPress

Thinking this was a change I had missed, I searched for a paragraph in the block inserter, but couldn't find one:
Add_New_Post_‹Gutenberg_Dev—_WordPress_1

It took me longer than I care to publicly admit to realize what was happening and re-enable the core blocks in the block manager. I thought if it happened to me, it could happen to others, and for someone less familiar with Gutenberg could be even more confusing than it was for me.

Proposed Solution
I think it makes sense to add a notice that there are [x] disabled block (similar to the block manager) somewhere to help users know what is happening. either to the bottom of the block inserter or in the block inserter when no matching blocks are found.

Similar to this message:
Add_New_Post_‹Gutenberg_Dev—_WordPress 2

I wasn't involved in the Block Manager at all so wanted to put this out there and hopefully get some feedback from someone more familiar with it before I worked up a PR.

@brentswisher brentswisher added [Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Aug 28, 2019
@brentswisher brentswisher self-assigned this Aug 28, 2019
@mapk mapk added the Needs Design Feedback Needs general design feedback. label Aug 28, 2019
@kjellr
Copy link
Contributor

kjellr commented Aug 28, 2019

That's a good point. I think at the minimum, we could do something like this:

Frame

Clicking the button would open up the Block Manager modal directly. If we want to be extra helpful, something like this could be cool:

Frame

@talldan
Copy link
Contributor

talldan commented Aug 29, 2019

That seems like a great idea @brentswisher!

@mapk
Copy link
Contributor

mapk commented Aug 29, 2019

I like the first mockup from Kjell's two ideas. Just show the number of blocks disabled with a button to open the block manager. The second mockup feels like it would need more refinements.

Can you implement mockup 1, @brentswisher ?

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Aug 29, 2019
@brentswisher
Copy link
Contributor Author

Thanks for @kjellr for the mockups! I agree with @mapk about liking the first version as well. It might be sometime next week before I have time to work on it with the holiday weekend coming up, but I'm on it :)

@brentswisher brentswisher added [Status] In Progress Tracking issues with work in progress and removed Needs Dev Ready for, and needs developer efforts labels Aug 29, 2019
@skorasaurus skorasaurus removed the [Status] In Progress Tracking issues with work in progress label Jan 4, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@mtias mtias added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants