Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed failure placeholder design is broken #19662

Closed
youknowriad opened this issue Jan 15, 2020 · 2 comments · Fixed by #19673
Closed

Embed failure placeholder design is broken #19662

youknowriad opened this issue Jan 15, 2020 · 2 comments · Fixed by #19673
Assignees
Labels
[Block] Embed Affects the Embed Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

Capture d’écran 2020-01-15 à 11 19 11 AM

I believe this should look closer to the embed default placeholder with the failure message and buttons under the input?

Capture d’écran 2020-01-15 à 11 20 15 AM

I guess this happened with the placeholder refactorings cc @jasmussen @ItsJonQ

@youknowriad youknowriad added [Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended labels Jan 15, 2020
@ItsJonQ ItsJonQ self-assigned this Jan 15, 2020
@ItsJonQ
Copy link

ItsJonQ commented Jan 15, 2020

@youknowriad Halloo! Thank you for spotting this! I just took a looksy 🤔

The error markup HTML element isn't playing nicely with the display: flex of the form. These changes were made 1+ year ago. Not too sure why it's popping up now.

Will work on this now, and submit a fix as soon as it's ready

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 15, 2020
@davemart-in
Copy link

This may or may not be related. I'm happy to create a separate issue if it's unrelated.

I noticed a couple of irregularities when a field and a button occupy the same row. Here are a couple examples of what I'm seeing:

RSS Block

rss-block

Embed Block

embed block

It seems like in both instances the input could benefit from being the same height as the button.

Hat tip to @jasmussen for pointing me to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants