Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Fix license check errors #19861

Closed
Tug opened this issue Jan 24, 2020 · 1 comment
Closed

[Monorepo] Fix license check errors #19861

Tug opened this issue Jan 24, 2020 · 1 comment
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Comments

@Tug
Copy link
Contributor

Tug commented Jan 24, 2020

This is part of the Monorepo effort (see #18508).

Some of the dependencies gutenberg-mobile currently has are not compatible with GPLv2. #19860 will be tracking the effort to rewrite those.

This issue will track the progress of fixing the CI script that checks licenses in dependencies (see https://travis-ci.com/WordPress/gutenberg/jobs/278293062).

We'll need to fix it by either moving some dependencies to devDependencies (react-native-community/cli) and/or updating the script to exclude some specific dependencies we know won't be distributed.

We have identified the following dependencies that needs to be moved to devDependencies:

gutenberg@7.2.0
└─┬ react-native@0.60.0-patched
  └─┬ @react-native-community/cli@2.10.0
    ├─┬ @react-native-community/cli-platform-ios@2.10.0
    │ └── xcode@2.0.0                  <- Apache 2.0 license
    ├─┬ inquirer@3.3.0
    │ ├── rx-lite@4.0.8                <- Apache 2.0 license
    │ └── rx-lite-aggregates@4.0.8     <- Apache 2.0 license
    ├─┬ metro@0.54.1
    │ └─┬ jest-haste-map@24.7.1
    │   ├── fb-watchman@2.0.0          <- Apache 2.0 license
    │   └── walker@1.0.7               <- Apache 2.0 license
    └─┬ plist@3.0.1
      └── xmldom@0.1.27                <- Apache 2.0 license
@Tug Tug added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jan 24, 2020
@dratwas dratwas mentioned this issue Feb 3, 2020
21 tasks
@ceyhun
Copy link
Member

ceyhun commented Apr 15, 2020

Updated list of dependencies:

gutenberg@7.7.1
└─┬ @wordpress/react-native-editor@1.21.0
  └─┬ react-native@0.61.5
    ├─┬ @react-native-community/cli@3.0.4
    │ ├─┬ inquirer@3.3.0
    │ │ ├── rx-lite@4.0.8                              <- Apache 2.0 license
    │ │ └─┬ rx-lite-aggregates@4.0.8                   <- Apache 2.0 license
    │ │   └── rx-lite@4.0.8  deduped                   <- Apache 2.0 license
    │ ├─┬ metro@0.56.4
    │ │ ├─┬ metro-inspector-proxy@0.56.4
    │ │ │ └── rxjs@5.5.12                              <- Apache 2.0 license
    │ │ └─┬ yargs@9.0.1
    │ │   └─┬ read-pkg-up@2.0.0
    │ │     └─┬ read-pkg@2.0.0
    │ │       └─┬ normalize-package-data@2.4.0
    │ │         └─┬ validate-npm-package-license@3.0.3 <- Apache 2.0 license
    │ │           ├── spdx-correct@3.0.0               <- Apache 2.0 license
    │ │           └─┬ spdx-expression-parse@3.0.0
    │ │             └── spdx-exceptions@2.1.0          <- Apache 2.0 license
    │ ├─┬ metro-config@0.56.3
    │ │ └─┬ metro@0.56.3
    │ │   └─┬ metro-inspector-proxy@0.56.3
    │ │     └── rxjs@5.5.12                            <- Apache 2.0 license
    │ └─┬ metro-core@0.56.3
    │   └─┬ jest-haste-map@24.7.1
    │     ├─┬ fb-watchman@2.0.0                        <- Apache 2.0 license
    │     │ └── bser@2.0.0                             <- Apache 2.0 license
    │     ├─┬ fsevents@1.2.9
    │     │ └─┬ node-pre-gyp@0.12.0
    │     │   └── detect-libc@1.0.3                    <- Apache 2.0 license
    │     ├─┬ sane@4.1.0
    │     │ ├── @cnakazawa/watch@1.0.3                 <- Apache 2.0 license
    │     │ ├── fb-watchman@2.0.0  deduped             <- Apache 2.0 license
    │     │ └── walker@1.0.7  deduped                  <- Apache 2.0 license
    │     └── walker@1.0.7 
    └─┬ @react-native-community/cli-platform-ios@3.0.0
      └── xcode@2.1.0                                  <- Apache 2.0 license

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 5, 2020
@ceyhun ceyhun closed this as completed Jun 10, 2020
@ceyhun ceyhun removed the [Status] In Progress Tracking issues with work in progress label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

No branches or pull requests

2 participants