Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text block RTL display does not honor left/right position #20123

Closed
webmandesign opened this issue Feb 9, 2020 · 2 comments
Closed

Comments

@webmandesign
Copy link
Contributor

Description

When displaying Media & Text block on RTL language website, the .wp-block-media-text.has-media-on-the-right displays the media on left and text on right. This is because the block uses CSS grid layout, which honors the RTL language direction. However, as we are setting the layout to "left" or "right" is should actually honor the physical direction, which is the same in every language.

Steps to reproduce

  1. Insert a Media & Text block into a post and set it to display the image/media on right.
  2. Preview the result on back-end/front-end for LTR language and then switch to RTL language (or use https://wordpress.org/plugins/rtl-tester/ plugin).

Expected behavior

Both LTR and RTL layouts should be identical regardless the language direction.

Screenshots

@webmandesign
Copy link
Contributor Author

Oh, sorry for the ticket, this was fixed by pull request #18764
I must have been previewing an older version of the SASS file!

@webmandesign
Copy link
Contributor Author

However, somehow related it a pull request #20125 that I've just submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant