-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites unscrollable on mobile after 7.5.0 update #20214
Comments
can confirm. same here |
I can confirm for every theme – but only if I use our individual self-created block suite. I tested Ghost Blocks, Ultimate Blocks and CoBlocks and they do work. Maybe there is a bug in our block collection. @frankyifei @arjendejong12 @glendaviesnz – do you have self-created blocks as well? Edit 1I'm getting deeper into it. After activating our personal block suite, there are a lot of styles, that shouldn't be there. In fact our block suite has no frontend styles at all as everything is saved in our theme. Edit 2
Edit 3Wrote an issue in create-gutenblock project: ahmadawais/create-guten-block#268 |
Yeah, I do have my own blocks created with cgb. Let's hope this gets resolved quickly! Thanks for getting deeper into this. |
@mariohamann feel free to send in a PR and post about the tests you did. I'll merge that. @asharirfan can you help with this? |
Closing as it seems to be a CGB bug loading editor styles in the frontend. |
CGB gives you all the code you can modify it. This PR must have solved the issue https://github.com/ahmadawais/create-guten-block/pull/267/files I suggest you update the cgb-scripts and your code manually Successfully published:
|
Hi @ockham, @youknowriad PR #20050 moved some styles form edit post to the block editor module that applied to the "html" element https://github.com/WordPress/gutenberg//blob/c219fed9e282a1c8467827edacf0b90303587497/packages/block-editor/src/components/editor-skeleton/style.scss#L3. The block editor may be used in contexts we are not expecting, e.g: maybe someone uses a small block editor for comments on a website. Would it make sense to revert the change back to the edit-post module? |
I don't think we should revert the change. What we should/can do though, is to only apply the global style if the "EditorSkeleton" component is mounted. (maybe by adding a className to html when it's mounted). Ideally we don't have to do this html styling at all but due to how scrolling work on mobile devices, it seems that it's the only solution we have for now. |
That seems like a nice solution, maybe just having an effect that on mount adds a class to html if html still has no the class would be enough? |
yes, this should work. |
I do not have self created blocks |
Maybe you use a third-party block which is based on create-guten-block?
|
Describe the bug
After the latest update (7.5.0), sites viewed on mobile cannot be scrolled anymore.
The following css is responsible for this:
inserted by the following file:
gutenberg/build/block-editor/style.css?ver=1581605516
, which it gets from the following.scss
file.The
style.css
file in version 7.4.0 doesn't contain this css.To reproduce
Steps to reproduce the behavior:
Expected behavior
Page should be scrollable.
The text was updated successfully, but these errors were encountered: