-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appender element in non-edited, placed reusable blocks #20558
Comments
I have tested this and discovered there is in fact some vertical spacing between the reusable blocks and other blocks. However, the appender block remains invisible. The root source of the problem is Before: After: The question here is - is this extra spacing intentional? Should it be there? I'll |
@adamziel: When the appender element is hidden (of unedited blocks) using CSS, .components-disabled .block-list-appender {
display: none;
} |
@strarsis The extra spacing is definitely there: When I inspect the appender, it looks like this: However, adding the CSS rule doesn't seem to fix it: I even tried removing all appender elements but no dice as well. Only when I remove Hence I wonder, if it was added intentionally to indicate that reusable block is different from other blocks. For example, when I select it, here's how it looks like: Design feedback appreciated! |
Does this PR fix this issue? It seems to be related? |
Describe the bug
The appender element (with
block-list-appender
class) is added to placed, reusable blocks that aren't even currently edited. This results in a transparent vertical space at the bottom of the reusable block, which causes visual vertical gaps between blocks.To reproduce
Steps to reproduce the behavior:
Expected behavior
The appender element in a reusable block is only inserted/displayed when it is actually added (where it makes sense).
The text was updated successfully, but these errors were encountered: