Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tumblr logo in social link options #21270

Closed
fetherston opened this issue Mar 30, 2020 · 2 comments · Fixed by #21329
Closed

Update Tumblr logo in social link options #21270

fetherston opened this issue Mar 30, 2020 · 2 comments · Fixed by #21329
Assignees
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@fetherston
Copy link

fetherston commented Mar 30, 2020

Describe the bug
Hi Gutenberg fam 🙌 full disclosure I work at Tumblr. The logo in the social links is our old logo. Can we update it?

https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/social-link/variations.js

The correct logo is at tumblr.com/logo

To reproduce
Steps to reproduce the behavior:

  1. Turn on Tumblr as a sharing option
  2. View Tumblr logo
  3. It's the Tumblr logo from 4-5 years ago

Expected behavior
The logo should be the new logo!

Screenshots
image

Desktop (please complete the following information):

  • Any and all!

Smartphone (please complete the following information):

  • All of um!

Additional context

  • Thanks for the help keep our branding up to date folks!
@mcsf
Copy link
Contributor

mcsf commented Mar 30, 2020

Hi! The two places in which to update the logo are:

  • Client-side:
    export const TumblrIcon = () => (
    <SVG width="24" height="24" viewBox="0 0 24 24" version="1.1">
    <Path d="M16.749,17.396c-0.357,0.17-1.041,0.319-1.551,0.332c-1.539,0.041-1.837-1.081-1.85-1.896V9.847h3.861V6.937h-3.847V2.039 c0,0-2.77,0-2.817,0c-0.046,0-0.127,0.041-0.138,0.144c-0.165,1.499-0.867,4.13-3.783,5.181v2.484h1.945v6.282 c0,2.151,1.587,5.206,5.775,5.135c1.413-0.024,2.982-0.616,3.329-1.126L16.749,17.396z" />
    </SVG>
    );
  • Server-side:
    'tumblr' => array(
    'name' => 'Tumblr',
    'icon' => '<svg width="24" height="24" viewBox="0 0 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" role="img" aria-hidden="true" focusable="false"><path d="M16.749,17.396c-0.357,0.17-1.041,0.319-1.551,0.332c-1.539,0.041-1.837-1.081-1.85-1.896V9.847h3.861V6.937h-3.847V2.039 c0,0-2.77,0-2.817,0c-0.046,0-0.127,0.041-0.138,0.144c-0.165,1.499-0.867,4.13-3.783,5.181v2.484h1.945v6.282 c0,2.151,1.587,5.206,5.775,5.135c1.413-0.024,2.982-0.616,3.329-1.126L16.749,17.396z"></path></svg>',
    ),

As you see, an SVG file is expected. Can you contribute with one? Thanks!

@mcsf mcsf added [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement. labels Mar 30, 2020
@fetherston
Copy link
Author

Oops sorry, forgot to leave this link: https://www.tumblr.com/logo. SVGs are available in that download.

@Soean Soean self-assigned this Mar 30, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants