Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection mode: add icon before the label #21479

Closed
jasmussen opened this issue Apr 8, 2020 · 1 comment
Closed

Selection mode: add icon before the label #21479

jasmussen opened this issue Apr 8, 2020 · 1 comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jasmussen
Copy link
Contributor

Extracting this individual task from #18667.

There is a visual connection between the block toolbar when you're editing, and the block toolbar when you are selecting. Here's the mockup for editing a cover block:

Here, that cover is "selected":

Here's what's currently shipping:

edit select

We should add icons to the selection mode toolbar and place them precisely so they stay in the same place when you are switching back and forth between selection and edit modes.

@jasmussen jasmussen added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Enhancement A suggestion for improvement. labels Apr 8, 2020
@jasmussen
Copy link
Contributor Author

Hooray! Fixed!

icons

I spotted in that GIF a discrepancy in the drag handle positioning but I'll fix that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

1 participant