Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: BlockList: Rename BlockContext as BlockListContext #21664

Closed
aduth opened this issue Apr 16, 2020 · 0 comments · Fixed by #21922
Closed

Block Editor: BlockList: Rename BlockContext as BlockListContext #21664

aduth opened this issue Apr 16, 2020 · 0 comments · Fixed by #21922
Assignees
@gziolo
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@aduth
Copy link
Member

aduth commented Apr 16, 2020

Previously: #21467 (#21467 (comment))

As of #21467, there are now three React Context objects related to blocks:

  • BlockContext in block-editor/src/components/block-list/block.js
  • BlockEditContext in block-editor/src/components/block-edit/context.js
  • BlockContext in block-editor/src/components/block/context/index.js

For fear of potential confusion, these should each have distinct names. Currently, there is conflict between the two "BlockContext" objects. The latter of these is responsible for managing the feature of the same name ("Block Context", implemented in #21467). The former is specific to the context of a block within the block list. As such, it is more easily renamed.

Task:

Rename BlockContext in block-list/block.js to BlockListContext or BlockListBlockContext.
@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality [Package] Block editor /packages/block-editor labels Apr 16, 2020
@aduth aduth mentioned this issue Apr 16, 2020
Merged
@gziolo gziolo mentioned this issue Apr 27, 2020
Merged
@gziolo gziolo self-assigned this Apr 27, 2020
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Editor: Rename block context in BlockListBlock WordPress/gutenberg
2 participants
@gziolo @aduth