Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: BlockContext: Opt-in BlockContext component to type checking #21666

Closed
aduth opened this issue Apr 16, 2020 · 0 comments · Fixed by #22353
Closed

Block Editor: BlockContext: Opt-in BlockContext component to type checking #21666

aduth opened this issue Apr 16, 2020 · 0 comments · Fixed by #22353
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress

Comments

@aduth
Copy link
Member

aduth commented Apr 16, 2020

Previously: #21467 (#21467 (comment))
Related: #18838
Blocked by: #21613

Context:

I'd hoped to include a bit of extra type-checking for the new @wordpress/block-editor file in f95972d. Unfortunately, while this worked in my (stale) local branch, dependent types were removed in #21613 as a result of some issues with this week's packages publishing.

Task:

Once the issue associated with #21613 is resolved, reintroduce the changes of 0ff9acda2dee96bf6f571aec27cb917ef664db05.

Note: This commit should have also included the following additional revision:

diff --git a/packages/block-editor/tsconfig.json b/packages/block-editor/tsconfig.json
index 7cd3fd793..61d1d214a 100644
--- a/packages/block-editor/tsconfig.json
+++ b/packages/block-editor/tsconfig.json
@@ -4,6 +4,9 @@
 		"rootDir": "src",
 		"declarationDir": "build-types"
 	},
+	"references": [
+		{ "path": "bin" },
+	],
 	// NOTE: This package is being progressively typed. You are encouraged to
 	// expand this array with files which can be type-checked. At some point in
 	// the future, this can be simplified to an `includes` of `src/**/*`.

It is necessary for all packages referenced by a file to be included in references.

Related documentation: https://github.com/WordPress/gutenberg/blob/master/packages/README.md#using-typescript

@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] Blocked Used to indicate that a current effort isn't able to move forward [Package] Block editor /packages/block-editor labels Apr 16, 2020
@aduth aduth removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 14, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block editor /packages/block-editor [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant