Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inserter search input-field classname breaks e2e/performance tests #22045

Closed
strarsis opened this issue May 1, 2020 · 2 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@strarsis
Copy link
Contributor

strarsis commented May 1, 2020

Describe the bug
The new classname of the search input-field of the inserter breaks the e2e/performance tests because the classname wasn't changed in the test utility functions yet.

Old class name: block-editor-inserter__search-input
New class name: block-editor-inserter__search

To reproduce
Steps to reproduce the behavior:

  1. Run the performance test script test-performance (after having prepared everything, also see test-performance build script: Add build:packages/wp-env start scripts as dependency #22038)
  2. Notice that the test will fail because of failing to focus on the element -block-editor-inserter__search-input.
  3. When you dump the DOM right before the line await page.focus( '.block-editor-inserter__search-input' ); in packages/e2e-test-utils/src/search-for-block.js:14 you will notice that the inserter search input field got the classname block-editor-inserter__search, but the e2e test utility expects the old classname block-editor-inserter__search-input, hence focusing it times out in puppeteer and the test fails.

Expected behavior
e2e/performance tests can finish without errors.

@talldan
Copy link
Contributor

talldan commented May 8, 2020

The performance tests in master passed ok for me.

The classname block-editor-inserter__search-input does still seem to be in use:

className="block-editor-inserter__search-input"

But maybe it was fixed in another ticket. I'll close this given I'm unable to reproduce the issue.

@talldan talldan closed this as completed May 8, 2020
@talldan talldan added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels May 8, 2020
@strarsis
Copy link
Contributor Author

strarsis commented May 8, 2020

@talldan: Probably another build task has to be run before the e2e tests and some built files are checked in, that had been built before that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

No branches or pull requests

2 participants