Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the gallery css output on front margins needed #2272

Closed
karmatosed opened this issue Aug 7, 2017 · 0 comments
Closed

Are the gallery css output on front margins needed #2272

karmatosed opened this issue Aug 7, 2017 · 0 comments
Labels
[Type] Question Questions about the design or development of the editor.

Comments

@karmatosed
Copy link
Member

karmatosed commented Aug 7, 2017

This is an issue purely with the front, rendered through a theme, not through the editor. Currently the gallery outputs a right margin on the front.:

.wp-block-gallery:not(.components-placeholder) { margin-right: -16px; }

These work ok on fixed themes - with a single body width. However, I am working on for the Gutenberg Theme a fluid width, allowing for things like full width images/content to be up to the editor. This comes into more play as we move to have layout.

For example, this doesn't work because of that margin:

.wp-block-gallery{ margin: 1.5em auto; max-width: 1100px; }

If you use a scary !important, it can be got around. I would suggest though that looking into if having a negative margin on the block is needed though. Happy if another work around also works. I mostly want to know why this is needed and can we avoid it?

@karmatosed karmatosed added the [Type] Question Questions about the design or development of the editor. label Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Question Questions about the design or development of the editor.
Projects
None yet
Development

No branches or pull requests

1 participant