Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop for Navigation block on navigation screen #23581

Closed
2 of 3 tasks
draganescu opened this issue Jun 30, 2020 · 3 comments
Closed
2 of 3 tasks

Drag and drop for Navigation block on navigation screen #23581

draganescu opened this issue Jun 30, 2020 · 3 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

draganescu commented Jun 30, 2020

We need to be able to use drag and drop on the navigation block that we use on the navigation screen to reorder items. However the challenge is that on the navigation screen the toolbar of the block is always fixed, so currently there isn't anything to drag from.

So far we've had three ideas to help this work:

  • Enable hovered when dragging as a state that shows sub-menus
  • Add the dragging chip functionality to the toolbar of the navigation item
  • Bring in the press and drag exploration
@draganescu
Copy link
Contributor Author

This issue actually covers two problems:

  • Any block that has that __experimentalCaptureToolbars setting has it's drag handle out of the visual context of the block that will be dragged. One result of this is the chip is offset.

  • There is no clear way on how to drop something in an area that is hidden. This seems to require a separate issue as it looks like a bigger standalone problem to be solved for all editor instances.

@talldan
Copy link
Contributor

talldan commented Aug 21, 2020

#24707 fixes the offset of the draggable chip

@draganescu
Copy link
Contributor Author

This seems to have been fixed with the addition of the drag handle to the Link block's toolbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants