Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer drag n drop blocks reliably and block toolbars disappear #23863

Closed
maddisondesigns opened this issue Jul 10, 2020 · 5 comments
Closed
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Package] Keyboard Shortcuts /packages/keyboard-shortcuts

Comments

@maddisondesigns
Copy link

Describe the bug
Just updated to Gutenberg 8.5 and can no longer drag n drop blocks reliably. When you click on a block you don't get any toolbar, drag handles, or even the Move up/down arrows.

I can consistently break it by dragging a block up the page, then hitting esc to undo the drag. From then on, Block Toolbars no longer display on any blocks, so you can't edit them, or drag them.

Here's a vid: https://share.getcloudapp.com/rRulDR4e

To reproduce
Steps to reproduce the behavior:

  1. Open a page with multiple blocks
  2. Click on a block and try to drag it to a new location
  3. Before dropping the block, hit esc
  4. Now try clicking on another block and the toolbars are broken and you can no longer edit the block or move it

Expected behavior
Moving blocks shouldn't be this difficult and inconsistent

Editor version (please complete the following information):

  • WordPress version: 5.4.2
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? [e.g: "gutenberg plugin", "default"] Plugin
  • If the Gutenberg plugin is installed, which version is it? 8.5.1

Desktop (please complete the following information):

  • OS: macOS Catalina 10.15.5
  • Browser: Firefox 78.0.1
  • TwentySeventeen
@annezazu annezazu added [Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Testing Needs further testing to be confirmed. labels Jul 10, 2020
@enriquesanchez
Copy link
Contributor

Hi @maddisondesigns 👋

I believe that what happened in your video is that when you clicked ESC you switched to 'Select' mode:

Screen Shot 2020-07-16 at 13 12 00

Currently, drag and drop is no supported in this mode, but if you were to click on the block label, the block's contents or hit Enter it should switch you back to 'Edit' mode, and you should be able to drag and drop again.

I agree that if someone's unfamiliar with these modes, this is an unexpected and confusing change.

@enriquesanchez enriquesanchez removed the Needs Testing Needs further testing to be confirmed. label Jul 16, 2020
@maddisondesigns
Copy link
Author

You're saying that by hitting esc, the editor is automatically changing it to the 'select' tool?? Why is it doing that? That's just horrible. Hitting esc should cancel the current action, not automatically change the editor into some other 'mode'. By doing this you're effectively making it impossible to cancel out of dragging a block. This is going to be incredibly frustrating for people editing their page. No-one is automatically going to assume that a different tool has been selected, because it literally makes no sense to do that, so everyone, like me, is just going to think that the editor has broken.

@draganescu draganescu added the [Package] Keyboard Shortcuts /packages/keyboard-shortcuts label Jul 21, 2020
@draganescu
Copy link
Contributor

This sounds like a bug where ESC in drag and drop mode should cancel the drag but not change the mode.

@enriquesanchez
Copy link
Contributor

I tested again and it looks like hitting ESCdoes cancel the operation, but the "dropzone bar" stays visible, which makes it look like the operation is still active.

2020-07-24 16-18-18 2020-07-24 16_20_19

@talldan
Copy link
Contributor

talldan commented Mar 3, 2021

I can't reproduce this any more, so closing.

@talldan talldan closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Package] Keyboard Shortcuts /packages/keyboard-shortcuts
Projects
None yet
Development

No branches or pull requests

5 participants