Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wide/full alignments for the query block container #27589

Closed
kjellr opened this issue Dec 8, 2020 · 5 comments · Fixed by #30804
Closed

Support wide/full alignments for the query block container #27589

kjellr opened this issue Dec 8, 2020 · 5 comments · Fixed by #30804
Assignees
Labels
[Block] Query Loop Affects the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Dec 8, 2020

The query block currently appears full-width in the editor by default, but it doesn't actually include standard/wide/full width controls for itself:

Screen Shot 2020-12-08 at 1 25 45 PM

This should potentially behave like a group block or template part, where it has its own width settings as a parent block.

@carolinan
Copy link
Contributor

Compared to the template part and group block, the query does not have an HTML element on the front, and I believe that is intended.
Would the alignment be passed to the inner block using context?

@kjellr
Copy link
Contributor Author

kjellr commented Jan 4, 2021

Right, sorry. I think the Query Loop block is the one that would need this control... It does wrap things in a ul on the front end right now:

Screen Shot 2021-01-04 at 9 07 54 AM

In any case, the root of the issue is that in my testing (Using TT1 Blocks), setting wide/full for blocks inside of the Query Loop block doesn't make them appear wide/full in the editor:

Screen Shot 2021-01-04 at 9 05 56 AM

(same thing happens in the front end, but that's the theme's responsibility to fix until there's a resolution to #26633.)

@ntsekouras
Copy link
Contributor

@kjellr is this PR: #30804 enough to close this issue?

@kjellr
Copy link
Contributor Author

kjellr commented Apr 27, 2021

Yes, I believe that would solve this specific issue. Now that the Query block has its own container, we were also discussing the ability for it to have its own layout controls. Is that still the plan?

@ntsekouras
Copy link
Contributor

we were also discussing the ability for it to have its own layout controls. Is that still the plan?

Yeah it is, although this might be a bit trickier due to some technical details with existing layout property and internal consumption of this prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants