Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme.json documentation with fontStyles, fontWeights, fontDecorations, fontTransforms presets #28197

Closed
ErikBernskiold opened this issue Jan 14, 2021 · 0 comments · Fixed by #29200
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@ErikBernskiold
Copy link

When updating an experimental theme project from Gutenberg 9.5 to Gutenberg 9.7, I noticed that all our font weights were suddenly missing. We were relying on the presets in experimental-theme.json.

After reviewing changelogs and issues closely, I think I've managed to find the PR where this was removed (#27555).

The documentation (https://developer.wordpress.org/block-editor/developers/themes/theme-json/) needs to be updated to reflect that these are no longer available.

A side note from the POV of an ecosystem developer:

These kind of changes are a big deal when following along with experimental theme projects, and projects extending upon Gutenberg. It would be nice, in general, if they get a little bit more attention in releases. It's not the small, trivial change that the PR makes it out to be.

@ErikBernskiold ErikBernskiold changed the title Update theme.json documentation with fontStylse, fontWeights, fontDecorations, fontTransforms presets Update theme.json documentation with fontStyles, fontWeights, fontDecorations, fontTransforms presets Jan 14, 2021
@skorasaurus skorasaurus added the [Type] Developer Documentation Documentation for developers label Jan 14, 2021
@carolinan carolinan self-assigned this Feb 21, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
3 participants