Compose: Add new useCopyToClipboard hook
#29643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Mar 8, 2021
| <ClipboardButton | ||
| text={ () => serialize( blocks ) } | ||
| role="menuitem" | ||
| className="components-menu-item__button" |
There was a problem hiding this comment.
Notice how we can use the MenuItem here instead of emulating it.
|
Size Change: +207 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Mar 16, 2021
|
|
||
| return ( | ||
| <ToolbarButton | ||
| className="components-clipboard-toolbar-button" | ||
| ref={ ref } | ||
| disabled={ disabled } | ||
| > | ||
| { hasCopied ? __( 'Copied!' ) : __( 'Copy URL' ) } |
There was a problem hiding this comment.
This changes the behavior from the button label change to snacker, I just want to make sure that this is what we want :)
youknowriad
reviewed
Mar 16, 2021
youknowriad
added
[Type] New API
|
If that's not what we want, I can change it back, but I thought that's what we want since we started doing it in other places. |
|
👋 Thanks for the ping! I understand this is the question of the day?
I always thought the button label change was a bit too unique. I'm personally leaning towards a snackbar being a better pattern for this. |
|
I agree the notification is better, and hopefully that integrates better with a11y announcements too. |
youknowriad
approved these changes
Mar 17, 2021
|
Great, thanks! |
This was referenced Mar 18, 2021
gziolo
changed the title
useCopyToClipboard hook
|
Why do we need to deprecate the |
|
The problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hook I created in #22224 is flawed because it would stop working if the ref is updated.
There's no way to fix the hook without changing the API, so I created a new hook and deprecated the flawed hook.
A lot of copy buttons have shifted from changing the button text on copy to a notice, so I removed the
hasCopiedstate from the hook, which would also be problematic to return if we have to return a ref.I also deprecated
ClipboardButton.How has this been tested?
Screenshots
Types of changes
Checklist: