Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the block settings menu, give it a background #2984

Closed
jasmussen opened this issue Oct 11, 2017 · 5 comments
Closed

Improve the block settings menu, give it a background #2984

jasmussen opened this issue Oct 11, 2017 · 5 comments
Assignees
@youknowriad
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jasmussen
Copy link
Contributor

The ellipsis menu introduced in 1.4 to hold the trash and configure settings is a bit flimsy on the side. We can improve this by making it an actual popout menu. Currently:

screen shot 2017-10-11 at 13 04 10

Suggested design:

screen shot 2017-10-11 at 13 07 01

See also #2983.

This would also be a good opportunity to show shortcut keys, see #2980.
@jasmussen jasmussen added General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take labels Oct 11, 2017
@jasmussen jasmussen mentioned this issue Oct 11, 2017
Closed
@karmatosed
Copy link
Member

I really like this! Let's get this into a PR so we can experience it. Great work.

@youknowriad youknowriad self-assigned this Oct 11, 2017
This was referenced Oct 11, 2017
Merged
Merged
@shaunsantacruz
Copy link
Contributor

This would also fix #3000

@shaunsantacruz
Copy link
Contributor

shaunsantacruz commented Oct 13, 2017 •
edited
Loading

Another issue this might fix #3021

@hedgefield
Copy link

hedgefield commented Oct 16, 2017 •
edited
Loading

Love it.

For mobile I would maybe keep the horizontal bar, though there is no need to put it into another menu there, as noted in #3021.

@jasmussen jasmussen mentioned this issue Oct 17, 2017
Closed
@mtias
Copy link
Member

mtias commented Nov 29, 2017

Closing as done.

@mtias mtias closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@karmatosed @youknowriad @mtias @jasmussen @shaunsantacruz @hedgefield