Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: reordering in media library not applied #30004

Closed
glendaviesnz opened this issue Mar 19, 2021 · 1 comment
Closed

Gallery block refactor: reordering in media library not applied #30004

glendaviesnz opened this issue Mar 19, 2021 · 1 comment
Assignees
@glendaviesnz
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

Description

If gallery images are re-ordered in the media library these changes in order are not applied when returning to the gallery block.

Step-by-step reproduction instructions

  1. Check out gallery refactor PR and turn on refactored gallery experiment
  2. Add a new gallery block with images
  3. Select media library from placeholder and then 'Edit gallery'
  4. Drag and drop to reorder images and then 'Update gallery'

Screenshots or screen recording (optional)

reorder-fail
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 19, 2021
@glendaviesnz glendaviesnz changed the title Gallery block refactor: reordering in media library not applie Gallery block refactor: reordering in media library not apply Mar 19, 2021
@glendaviesnz glendaviesnz changed the title Gallery block refactor: reordering in media library not apply Gallery block refactor: reordering in media library not applied Mar 22, 2021
@glendaviesnz glendaviesnz mentioned this issue Mar 22, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 22, 2021
@glendaviesnz
Copy link
Contributor Author

Fixed by #30070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glendaviesnz