Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Logo Block: The icon color shouldn't be hardcoded #30087

Closed
Copons opened this issue Mar 22, 2021 · 3 comments · Fixed by #30211
Closed

Site Logo Block: The icon color shouldn't be hardcoded #30087

Copons opened this issue Mar 22, 2021 · 3 comments · Fixed by #30211
Assignees
@mtias
Labels
[Block] Site Logo Affects the Site Logo Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@Copons
Copy link
Contributor

Copons commented Mar 22, 2021

The Site Logo icon's color is hardcoded as black.

https://github.com/WordPress/gutenberg/blob/82054044571f7073010a1aae77e7ee3f0335e5bf/packages/block-library/src/site-logo/icon.js

This is generally fine, but there are cases where it's used against a dark background, and we need to change its color.
See for example the List View, when the block is selected:

Screenshot 2021-03-22 at 11 19 29
@Copons Copons added [Type] Bug An existing feature does not function as intended [Block] Site Logo Affects the Site Logo Block labels Mar 22, 2021
@ntsekouras
Copy link
Contributor

Whoever picks this up, has to fix the line's stroke color as well.

@ntsekouras ntsekouras added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Mar 23, 2021
@mtias
Copy link
Member

mtias commented Mar 23, 2021

The icon as a whole should be changed cc @pablohoneyhoney

@pablohoneyhoney
Copy link

pablohoneyhoney commented Mar 23, 2021 •
edited
Loading

Here two first tries.

site logo2

site logo

Full disclosure I haven't tried in context, so worth passing that test. Quick design is vailable in the regular open Figma file of icons, on the explorations board. https://www.figma.com/file/e4tLacmlPuZV47l7901FEs/WordPress-Design-Library?node-id=8%3A13

@mtias mtias mentioned this issue Mar 24, 2021
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtias mtias

Labels
[Block] Site Logo Affects the Site Logo Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Icons: Update site-logo block icon. WordPress/gutenberg
4 participants
@mtias @Copons @ntsekouras @pablohoneyhoney