Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Focal Point Picker Size #31111

Closed
mkaz opened this issue Apr 22, 2021 · 1 comment
Closed

Site Editor: Focal Point Picker Size #31111

mkaz opened this issue Apr 22, 2021 · 1 comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@mkaz
Copy link
Member

mkaz commented Apr 22, 2021 •
edited
Loading

Description

When using the Cover Block in the Site Editor, the image shown in the focal point picker is too large, likewise the picker itself appears to be ovesized and not placed properly.

cover-focal.mp4

Step-by-step reproduction instructions

  1. Using site editor, editing a template
  2. Add a Cover Block
  3. Add a large image
  4. Confirm focal point image and picker are incorrect size

Tested on trunk today, but also against v10.5.0-rc.1 tag
@mkaz mkaz added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 22, 2021
@mkaz
Copy link
Member Author

mkaz commented Apr 23, 2021

Using git bisect I tracked down this issue to: #31010
But after an update and test it is now fixed in: #31073

@mkaz mkaz closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkaz