Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word-block count and table of contents popover accessibility #3216

Closed
afercia opened this issue Oct 28, 2017 · 8 comments
Closed

Word-block count and table of contents popover accessibility #3216

afercia opened this issue Oct 28, 2017 · 8 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Oct 28, 2017

Follow up to #2684. Thought there was already an issue open for this but couldn't find it. Feel free to close this if I've missed it.

screen shot 2017-10-28 at 16 17 39

There are still some issues to address:

  • placement of the "I" button as discussed on Add word and block count to table of contents #2684 and Open/close sidebar interaction is un-intuitive #3166
  • the toggle button "I" is empty and misses any accessible name. It used to have a visible "Info" text that was removed in 7e3cc89 without providing any alternate name to the button. As a consequence, there's nothing assistive technologies can announce other than "button"
  • the toggle button should have an aria-expanded attribute
  • it's an "icon-only" button, I wonder if it should use a tooltip as similar buttons do
  • focus management: this is a general issue for the Dropdown (formerly "PopOver") component
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 28, 2017
@mtias
Copy link
Member

mtias commented Nov 20, 2017

@afercia do we have pending items here?

@afercia
Copy link
Contributor Author

afercia commented Nov 20, 2017

@mtias couple issues to consider:

1
When there are headings, opening the "Content Structure" move the initial focus to the first heading in the ToC. Not so ideal because all the previous content (the counts) get skipped.

2
Tabbing should be constrained within the Dropdown (formerly "PopOver") but I guess this should be addressed in that component. Is there already a specific issue for that?

I've noticed also a couple layout/usability potential problems, going to open a new issue.

@afercia
Copy link
Contributor Author

afercia commented Mar 12, 2018

Many things have changed here, I think this can be closed now.

@mtias
Copy link
Member

mtias commented Mar 12, 2018

about initial focus when there are no headings, I'm going to push a PR

Cool. I was thinking of a general solution as well where we can move focus to a popover but don't have to focus any specific item within it.

@mtias mtias closed this as completed Mar 12, 2018
@afercia
Copy link
Contributor Author

afercia commented Mar 12, 2018

Hm the pattern recommended by the ARIA authoring practices is to always move focus to the first focusable element inside a popover or menu. We're discussing this in a separate issue, see #5559

@mtias
Copy link
Member

mtias commented Mar 12, 2018

We have gotten some feedback from users who don't expect a first item to be selected and confuse the focus ring with a heading style.

I think the prevalence of menus like these, that focus on the thing that opened the menu, contribute to that feeling:

image

@afercia
Copy link
Contributor Author

afercia commented Mar 12, 2018

Please refer to the ARIA resources posted on #5559. Moving focus to the first item is a requirement. We shouldn't try to solve what is a styling issue at the expenses of a required functionality.

@mtias
Copy link
Member

mtias commented Mar 12, 2018

I don't think it's a styling issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants