Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Navigation with Arrows does not work in Block Settings #3223

Closed
2 tasks
ephox-mogran opened this issue Oct 30, 2017 · 1 comment
Closed
2 tasks
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@ephox-mogran
Copy link
Contributor

Issue Overview

Keyboard navigation does not work in the block settings dropdown, I'm not sure if there is an easy way to focus it at the moment. I'm currently using the mouse.

Note, the tab key works, but the arrow keys do not. Every time we don't capture the arrow keys, they propagate up to WritingFlow and there is a jarring block focus shift.

Steps to Reproduce (for bugs)

  1. Click on the block settings dropdown
  2. Press the down button to focus the next item

Expected Behavior

The next item in the menu should be focused

Current Behavior

The menu is closed, and some other block is focused

Possible Solution

Arrow keys need to be captured in a lot more places, or WritingFlow has to stop trying to handle them.

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@ephox-mogran ephox-mogran added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 30, 2017
@aduth
Copy link
Member

aduth commented Mar 1, 2018

Closed in favor of #5245

@aduth aduth closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants