Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should handle esc key events #35496

Closed
github-actions bot opened this issue Oct 11, 2021 · 10 comments · Fixed by #41312
Closed

[Flaky Test] should handle esc key events #35496

github-actions bot opened this issue Oct 11, 2021 · 10 comments · Fixed by #41312
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Oct 11, 2021

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should handle esc key events

Test path

/test/e2e/specs/widgets/customizing-widgets.spec.js

Errors

[2021-10-11T05:53:59.208Z] Test passed after 1 failed attempt on trunk.
[2022-05-23T19:21:29.958Z] Test passed after 1 failed attempt on fix/env-wp-tests-config.
[2022-05-24T05:58:38.796Z] Test passed after 1 failed attempt on try/style-engine-block-supports-elements.
[2022-05-24T06:13:21.655Z] Test passed after 2 failed attempts on update/use-user-event-in-TimePicker-tests.
[2022-05-24T09:07:57.039Z] Test passed after 1 failed attempt on add/more-template-types-site-editor.
[2022-05-24T09:33:00.632Z] Test passed after 2 failed attempts on update/block-supports-skip-serialization-docs.
[2022-05-25T01:35:31.697Z] Test passed after 1 failed attempt on update/layout-to-support-full-width.
[2022-05-25T04:26:58.932Z] Test passed after 1 failed attempt on rnmobile/add-waits-non-text-blocks.
[2022-05-25T11:26:08.052Z] Test passed after 1 failed attempt on refactor/rever-template-test.
[2022-05-25T15:12:32.704Z] Test passed after 1 failed attempt on update/modal-UI.
[2022-05-25T16:32:24.632Z] Test passed after 1 failed attempt on rnmobile/update/react-native-gesture-handler-2.3.2.
[2022-07-29T18:53:22.666Z] Test passed after 1 failed attempt on add/archive-post-type-template-ui.
[2022-08-01T04:23:15.781Z] Test passed after 1 failed attempt on update/control-labels.
[2023-05-11T06:45:47.511Z] Test passed after 1 failed attempt on trunk.
TimeoutError: page.click: Timeout 10000ms exceeded.
=========================== logs ===========================
waiting for locator('role=heading[name=/Footer #1/i][level=3]')
============================================================
    at WidgetsCustomizerPage.expandWidgetArea (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/widgets/customizing-widgets.spec.js:647:19)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/widgets/customizing-widgets.spec.js:445:3
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Oct 11, 2021
@kevin940726
Copy link
Member

Hopefully fixed by #39540.

@github-actions github-actions bot reopened this May 18, 2022
@kevin940726
Copy link
Member

Interesting, it seems to be a legitimate bug in the customizer. Here's the recorded video:

video.mp4

@kevin940726
Copy link
Member

It seems like the block popover is being rendered in the wrong place. The "Options" button is covered by the editor sidebar. I don't know if there's any change being done related to the block popover?

@youknowriad
Copy link
Contributor

This seems indeed related to #40740 I'll try to take a look. Do you know what's the expectation here, how should the block toolbar render?

@Mamaduka
Copy link
Member

@youknowriad, this is how the toolbar is rendered in WP 6.0 without the plugin.

CleanShot 2022-05-25 at 14 21 47

@ciampo
Copy link
Contributor

ciampo commented Jul 29, 2022

Didn't have time to investigate, but could be related to #42417 (cc @talldan @ntsekouras )

@ciampo
Copy link
Contributor

ciampo commented Aug 5, 2022

I've been playing around with the "Widgets" section in the Customizer but all toolbars seems OK to me

Screenshot 2022-08-05 at 09 17 35
Screenshot 2022-08-05 at 09 17 27

Hey @Mamaduka ! Since you helped tracking down this regression previously (and reviewed Riad's fix), maybe you could help me to understand is this is still an issue or not? Thank you 🙏

@Mamaduka
Copy link
Member

Mamaduka commented Aug 5, 2022

Thanks for the ping, @ciampo. I can have a look next week if that's alright. I need a bit of a refresher on this issue 😄

@ciampo
Copy link
Contributor

ciampo commented Aug 5, 2022

Absolutely, no rush!

@github-actions
Copy link
Author

github-actions bot commented Sep 5, 2022

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 5, 2022
@github-actions github-actions bot closed this as completed Sep 6, 2022
@github-actions github-actions bot reopened this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants