Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block patterns loading inconsistently #35852

Closed
dingo-d opened this issue Oct 21, 2021 · 8 comments
Closed

Block patterns loading inconsistently #35852

dingo-d opened this issue Oct 21, 2021 · 8 comments
Labels
Customization Issues related to Phase 2: Customization efforts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@dingo-d
Copy link
Member

dingo-d commented Oct 21, 2021

Description

When I register custom blocks and want to use them in the editor, sometimes they render out fine in the dropdown, and sometimes I only see the name of the pattern.

And no errors in the console, or debug log.

Step-by-step reproduction instructions

  1. Create a custom pattern
  2. Create a custom pattern category
  3. Remove core patterns (because they don't fit with what we want to offer to the client)
  4. Load the patterns

Screenshots, screen recording, code snippet

image

Three patterns load fine. Two don't.

Why?

Who knows 🤷🏼‍♂️

Environment info

  • WP 5.8.1, core editor, custom theme
  • Chrome, FF, Edge
  • Windows 11 Desktop, or Mac OS MBP laptop

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan
Copy link
Contributor

carolinan commented Oct 22, 2021

-Is it the same pattern that doesn't load? What happens if you remove all patterns except the erroring?
Did you confirm that the pattern is valid?
Do they work if you enable Gutenberg?

@dingo-d
Copy link
Member Author

dingo-d commented Oct 22, 2021

Patterns are valid, as they render out fine when I select them. The issue doesn't come from a pattern. Sometimes one is showing, sometimes not, and the same for others. I cannot reproduce the bug with any consistency, which makes this super hard to debug.

I haven't tried it out in a plugin, just the core editor so far.

@stevenlinx stevenlinx added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended Customization Issues related to Phase 2: Customization efforts Needs Testing Needs further testing to be confirmed. labels Oct 25, 2021
@Mamaduka
Copy link
Member

Mamaduka commented Aug 9, 2022

@dingo-d, we fixed a few bugs related to pattern rendering in WP 5.9 (#38175). Are you still able to reproduce the issue with the current major WP version?

@Mamaduka Mamaduka removed the Needs Testing Needs further testing to be confirmed. label Aug 9, 2022
@abhansnuk
Copy link

As in today's bug scrub, pre 6.0 release, I could reproduce this issue when Gutenberg was not enabled. It applied to the third pattern to display, and not one particular pattern. With Gutenberg enabled, I could not reproduce it.

Today on retesting, post 6.0 release, I can not currently reproduce the issue with Gutenberg enabled or not.

@dingo-d
Copy link
Member Author

dingo-d commented Aug 10, 2022

For me, they do load now, but something is broken in how they are rendered, so I need to check out more about what happened here...

@annezazu
Copy link
Contributor

@dingo-d I'm going to close this out for now as it doesn't appear this issue is still active. Please comment back here though if that's not the case! I'm always happy to reopen and reinvestigate.

@dingo-d
Copy link
Member Author

dingo-d commented May 11, 2023

@annezazu I think there is another issue opened that I've commented on (cannot for the life of me find it atm) where there is no style applied to the patterns preview at all.

@annezazu
Copy link
Contributor

Feel free to @ me on that issue but I am only closing this one out for now. I'll see if I can perhaps find the same one today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization Issues related to Phase 2: Customization efforts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants