Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 5.9 theme.json schema doesn't allow setting the "version" property to 2 #38242

Closed
mrleemon opened this issue Jan 26, 2022 · 5 comments
Closed
Assignees
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@mrleemon
Copy link
Contributor

mrleemon commented Jan 26, 2022

Description

The new Twenty Twenty-Two theme ships with a theme.json file with the "version" property set to 2, but the WP 5.9 theme.json schema (https://schemas.wp.org/wp/5.9/theme.json) just allows the 1 value.

Step-by-step reproduction instructions

  1. Open a version 2 theme.json file with VS Code
  2. Add the WP 5.9 theme.json schema (https://schemas.wp.org/wp/5.9/theme.json) to it
  3. The "version" property is highlighted (Value is not accepted)

Screenshots, screen recording, code snippet

schema

Environment info

  • WordPress 5.9

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@annezazu annezazu added [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended Developer Experience Ideas about improving block and theme developer experience labels Jan 26, 2022
@annezazu
Copy link
Contributor

@mkaz @ryanwelcher can you all chime in here based on your work in this area?

@ryanwelcher
Copy link
Contributor

Looks like it needs to be updated in the 5.9 branch - https://github.com/WordPress/gutenberg/blob/wp/5.9/schemas/json/theme.json#L1070.

@ryanwelcher
Copy link
Contributor

@ajlende do we need to cherry-pick #36917 into the 5.9 branch?

@ajlende
Copy link
Contributor

ajlende commented Jan 28, 2022

This affected more than just the version tag. It looks like not all of the commits were labeled for inclusion in the release. I added the Backport to WP Minor Release label to everything affected, so the changes should be reflected when 5.9.1 lands.

@ocean90
Copy link
Member

ocean90 commented Feb 16, 2022

The version was updated in b23854a.

@ocean90 ocean90 closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants