Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference docs for theme.json: pull data from keys other than settings and styles #38620

Closed
oandregal opened this issue Feb 8, 2022 · 1 comment · Fixed by #48250
Closed

Reference docs for theme.json: pull data from keys other than settings and styles #38620

oandregal opened this issue Feb 8, 2022 · 1 comment · Fixed by #48250
Assignees
@carolinan
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.

Comments

@oandregal
Copy link
Member

oandregal commented Feb 8, 2022 •
edited
Loading

See https://github.com/WordPress/gutenberg/pull/38323/files#r801524958

The reference docs for theme.json only contains data coming from the settings and styles keys. There are some missing sections, such as customTemplates, templateParts, or the patterns key being added #38323
@oandregal oandregal added [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 8, 2022
@oandregal oandregal mentioned this issue Feb 8, 2022
Merged
@oandregal
Copy link
Member Author

cc @ajlende @ryanwelcher

@carolinan carolinan self-assigned this Feb 20, 2023
@carolinan carolinan mentioned this issue Feb 20, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update theme.json reference docs to include more sections WordPress/gutenberg
2 participants
@oandregal @carolinan