Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting margins for embeds #39339

Closed
carolinan opened this issue Mar 10, 2022 · 5 comments
Closed

Allow setting margins for embeds #39339

carolinan opened this issue Mar 10, 2022 · 5 comments
Labels
[Block] Embed Affects the Embed Block [Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.

Comments

@carolinan
Copy link
Contributor

What problem does this address?

If you want a design with some additional top and/or bottom spacing around embeds, for example a Youtube video,
you need to add spacing blocks or place the embed inside a container, and add the spacing to the container.

What is your proposed solution?

Enable top and bottom margin controls for embeds and the video block.

@carolinan carolinan added [Block] Video Affects the Video Block [Block] Embed Affects the Embed Block [Type] Enhancement A suggestion for improvement. labels Mar 10, 2022
@carolinan
Copy link
Contributor Author

The reason why I am suggesting top and bottom margin only is that I am assuming that if you are aligning multiple videos horizontally, you are more likely to already be using a column or row as a container, and you would use the container block gap to space the items.

@HILAYTRIVEDI
Copy link
Contributor

HILAYTRIVEDI commented Mar 11, 2022

Hi @carolinan, Thank you for this suggestion, I think we can also add the left and right margin if someone wants to add the embedded block without any column or container.

@KokkieH
Copy link

KokkieH commented Apr 6, 2022

In terms of left/right margins, I have a case in the forums where text wrapping around a right-aligned Youtube embed goes right up to the edge of the embed. This enhancement should help prevent this type issue.

@HILAYTRIVEDI
Copy link
Contributor

Hi @KokkieH, Thank you for the reference that's really helpful. I agree with your point, that allowing the left/right margin to be controlled will help the user to remove this kind of issue.

@skorasaurus
Copy link
Member

this has been implemented in both the embed and video blocks in #39384 and #43365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants