-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting margins for embeds #39339
Comments
The reason why I am suggesting top and bottom margin only is that I am assuming that if you are aligning multiple videos horizontally, you are more likely to already be using a column or row as a container, and you would use the container block gap to space the items. |
Hi @carolinan, Thank you for this suggestion, I think we can also add the left and right margin if someone wants to add the embedded block without any column or container. |
In terms of left/right margins, I have a case in the forums where text wrapping around a right-aligned Youtube embed goes right up to the edge of the embed. This enhancement should help prevent this type issue. |
Hi @KokkieH, Thank you for the reference that's really helpful. I agree with your point, that allowing the left/right margin to be controlled will help the user to remove this kind of issue. |
What problem does this address?
If you want a design with some additional top and/or bottom spacing around embeds, for example a Youtube video,
you need to add spacing blocks or place the embed inside a container, and add the spacing to the container.
What is your proposed solution?
Enable top and bottom margin controls for embeds and the video block.
The text was updated successfully, but these errors were encountered: