Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications should always display on the screen for saving and updating #3971

Closed
davidwolfpaw opened this issue Dec 13, 2017 · 2 comments
Closed
Labels
[Type] Bug An existing feature does not function as intended
Milestone

Comments

@davidwolfpaw
Copy link

Issue Overview

When a post is edited in Gutenberg and a draft is saved, published, or a published post is updated, a notification appears at the top of the post informing if it has successfully posted or has failed.

When a post is long enough that the top of the post is no longer visible on the screen this notification is still produced, but it occurs offscreen.

This could result in users saving a draft, believing that they have successfully saved, then closing the browser and losing work if there was an error.

Steps to Reproduce (for bugs)

  1. Create a draft post that is longer than the height of your browser
  2. Save or update that post to get a success or failure notification

Possible Solution

Make the notifications fixed, or place them outside of the flow of the document editor.

Screenshots

screenshot 2017-12-13 08 39 43

screenshot 2017-12-13 08 40 03

@karmatosed
Copy link
Member

I agree that notifications should be always visible and that was the intent.. you've found a bug! Thanks for testing and let's get that fixed.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label Dec 14, 2017
@karmatosed karmatosed added this to the 2.0.0 milestone Dec 14, 2017
@jorgefilipecosta
Copy link
Member

With the merge of #4130, this should be fixed.Thank you for reporting this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants