Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive image gallery block #4035

Closed
pyronaur opened this issue Dec 15, 2017 · 3 comments
Closed

Responsive image gallery block #4035

pyronaur opened this issue Dec 15, 2017 · 3 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@pyronaur
Copy link
Contributor

Issue Overview

Galleries alignment is off on mobile devices:

alignment

Caused by:

	margin: 0 16px 16px 0;

at .wp-block-gallery.aligncenter .blocks-gallery-image, .wp-block-gallery.alignleft .blocks-gallery-image, .wp-block-gallery.alignright .blocks-gallery-image, .wp-block-gallery .blocks-gallery-image

Possible Solution

Maybe use CSS Grid instead of Flexbox? People with CSS grid will get a column of images, which isn't all that bad. By using grid margin could be replaced with grid-gap - this seems like the exact thing the grid spec was designed for.

If CSS Grid isn't an option - that margin needs to be cleared up so that the gallery causing an unsymmetrical 16px gap on the right.

@karmatosed
Copy link
Member

CSS Grid is planned to be used @justnorris, so a great idea to bring it in for this.

@jasmussen
Copy link
Contributor

I'll take this one.

@jasmussen
Copy link
Contributor

This issue is fixed by #5217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants