Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Block undo/redo goes letter by letter #4057

Closed
jaschaio opened this issue Dec 18, 2017 · 6 comments
Closed

Title Block undo/redo goes letter by letter #4057

jaschaio opened this issue Dec 18, 2017 · 6 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@jaschaio
Copy link

I think the history undo and redo buttons for the title block should work like within the paragraph block. The state should only change once the user stops typing and not after each letter.

Wrong Behaviour:
title

Correct Behaviour:
text

@aduth
Copy link
Member

aduth commented Dec 18, 2017

Related: #2932
Slated to be fixed by #4008

@afercia
Copy link
Contributor

afercia commented Jan 25, 2018

Hm, I'm not sure I agree. Ideally, the undo/redo behavior should work exactly like in the current editor because that's what users would expect. I know that under the hood, things work differently in Gutenberg and I'm not sure if that's feasible.

@jeffpaul jeffpaul added [Type] Enhancement A suggestion for improvement. [Status] In Progress Tracking issues with work in progress labels Jan 26, 2018
@jeffpaul jeffpaul added this to the Bonus Features milestone Jan 26, 2018
@aduth
Copy link
Member

aduth commented Jan 30, 2018

Hm, I'm not sure I agree. Ideally, the undo/redo behavior should work exactly like in the current editor because that's what users would expect. I know that under the hood, things work differently in utenberg and I'm not sure if that's feasible.

Not clear what you disagree with. The behavior of the classic editor is in line with what's being suggested by the original comment

undo

@afercia
Copy link
Contributor

afercia commented Jan 30, 2018

Sorry I misread the issue.

@mtias mtias removed the [Status] In Progress Tracking issues with work in progress label Mar 6, 2018
@mtias
Copy link
Member

mtias commented Mar 6, 2018

@aduth removing in progress label as it doesn't seem we have open PRs for it anymore.

@aduth
Copy link
Member

aduth commented Mar 6, 2018

The changes in #4956 set a foundation for this to occur in that, similar to how we batch sequential block updates, we can batch sequential post updates for the same property (i.e. edits.post_title).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants