Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher contrast block identification border #41261

Open
bdurette opened this issue May 23, 2022 · 6 comments
Open

Higher contrast block identification border #41261

bdurette opened this issue May 23, 2022 · 6 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@bdurette
Copy link
Contributor

What problem does this address?

When I hover the mouse over a block in the List View, the editor helpfully highlights the block by adding a 1 pixel blue border. However, this blue color is not always high contrast with the background for the highlighted block, so it's sometimes hard to see.

The following screenshot was taken with the mouse over the Paragraph block. I can barely make out the blue rectangle around the block:

Screen Shot 2022-05-23 at 2 52 31 PM

What is your proposed solution?

It would be great if the highlight color was dynamically selected to be one that is high contrast with the existing background, so that regardless of my theme/color settings, I get the benefit of the block identification border.

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. General Interface Parts of the UI which don't fall neatly under other labels. labels May 23, 2022
@karmatosed
Copy link
Member

Whilst I like the idea of contrasting with the background I can see this potentially getting really confusing if you have multiple colors. Perhaps another option is to not use color to denote alone?

@bdurette
Copy link
Contributor Author

bdurette commented May 25, 2022

That is a good point about multiple colors causing confusion. Looking at some prior art for this, Google Slides highlights the selected element with two different colors. One thick outline in a light color and a thin outline in a dark color, with the dark being centered inside the light. Thus, there's always contrast, regardless of the background color. I wonder if something like that would be better than trying to dynamically select color.

I do think that visually highlighting the selected element is quite useful. I don't know how you would do that without implicating color in some way.

@annezazu
Copy link
Contributor

annezazu commented Feb 8, 2024

@SaxonF @noisysocks I am really feeling this problem when I was making a youtube video to show off the new work to flash block outlines: #58159

Check out how hard it is to see the outlines, depending on the style variation:

block.outline.mov

Whew, it's almost impossible to see! I wonder how we can iterate here.

@noisysocks
Copy link
Member

Really good point. The outline colours are currently set to the admin theme colour. It should probably be set to (a rotation of?) a theme colour instead.

@annezazu
Copy link
Contributor

Really good point. The outline colours are currently set to the admin theme colour. It should probably be set to (a rotation of?) a theme colour instead.

Yes. The more I play around with it and appreciate the value it adds, the more I worry about how easy for this to get completely lost with common colors. Happy to open a separate issue if it helps to address this at least for the flashing outlines or maybe perhaps it can be addressed holistically? :)

@noisysocks
Copy link
Member

Holistically makes sense I think since the block outlines and editable outlines share a design vocabulary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants