-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Inserter: Next #41379
Comments
Exciting path! I like the scalability of this model. It's also a good example to explore in motion, and define how the second panel transitions between patterns smoothly as well as how they are dropped and rendered in the canvas. A few granular notes on the above mock, to address when/where relevant:
|
Inserter sidebar-editor.mp4Favourites Library There is room to simplify the mental model surrounding blocks, so the idea of reusable blocks would go away and just become a property of blocks/patterns (maybe all library items are synced by default). It should also differentiate between user created vs others e.g. via sections. It has the potential to draw in new segments who are more systems focused (e.g. designers, enterprise etc). You can read some earlier thoughts here. library-waterfall.mp4library.mp4 |
Nice! The library itself could be a separate effort and issue all together. It also opens up a lot of other discussions and changing mental models (like the current synced blocks navigation and management versus being a property, which is interesting). Re: the pattern inserter itself, I think we lost a bit of focus on the pattern insertion, instead of blocks' (which could remain as is for now). I also appreciated the clarity of the three panels distinguishing them via bg color (white for category listing, grey for pattern stacks, and site color for the canvas). |
I'd be happy to setup a dedicated issue for this. There are a few separate threads like this and this that are worth pulling together.
Any thoughts on how to do this without fragmenting the block inserter? I feel pretty strongly that we need to be designing in a way that minimises adding additional complexity to an already complex system/mental model/interface. For this reason I would hesitate to design a pattern insertion experience that differs from blocks, so I'd propose we make changes to the inserter as a whole. The combination of generic canvas zoom settings, parent element selection on patterns, patterns absorbing child block settings, and removing tabs in the inserter as shown here feels like a great first start point for putting more emphasis on patterns without adding a dedicated mode. A lot of these changes have benefits beyond just patterns as well. |
I think that's essentially how it would work in the mean time, if this feature were introduced as a part of the zoomed out view: zoomed-out.mp4 |
I think it's important block and pattern insertion works the same regardless of how the canvas is presented, at least in core. Zoom to me is really just a zoom setting as opposed to a separate view. Eg I may want to insert blocks while zoomed out or insert patterns while zoomed in. |
Oh I agree. I was just highlighting that we can potentially try this (in the plugin) in that 'view' since it lends itself to working with patterns already. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I like this one: I wouldn't want to touch how block are presented as that adds a lot more trouble. There's value in bringing the display and browsing improvements to the pattern section first. The row of block shortcuts in the header is a nice thing to try because it can make quickly adding common items faster yet not intrusive. We need to figure out how we handle focus since right now we move to search first. That might still make the most sense for keyboard nav, with shortcuts being more of a secondary affordance. |
To those subscribed, this issue has been updated with the mockups to implement. |
First of all, sorry if this has already been discussed or requested. Just a request for this issue 👍 1: Hover is better than Select I think it is better to “hover” each section than to “select” it in order to look for design inspiration. Ref: https://shuffle.dev demo page 2: Avoid reloading same pattern multiple times. [Just an idea to solve]
|
Is this now implemented in #44028? Should we close this now, or is there anything else left to implement? |
I think we can close. If anyone disagrees feel free to reopen 😁 |
Hi there 👋 In #44028 it looks like the pattern item title was visually hidden: gutenberg/packages/block-editor/src/components/inserter/style.scss Lines 314 to 316 in 25aa4b4
While that may work well for patterns with a lot of visual variation between them, I'm finding it a step back for patterns that are less visually striking. For example, text based patterns that look very similar to each other are a chore to locate now. And for third-party pattern additions, I also wonder if it makes it harder in referencing those patterns for users without relying on search (e.g., Navigate to Patterns > Business Templates > ??? ) |
@samiff -- mind opening a new issue about this and sharing a few examples? Feel free to @ me in it and I can make sure to get the right labels on it. |
@jameskoster I'd still like to try the shortcuts in the main header when the inserter is open for text, image, etc. |
We can still keep this close, it's a minor thing! |
Okay I'll open a separate issue. |
Previously #21080 (comment)
With the focus on "building with patterns" and the expansion of the pattern directory there's a need to refine some flows around the discovery and insertion of patterns. The main things to accommodate are the growing sets of categories and provenance (theme, directory, eventually user); the drag and drop experience when building top level sections; quick browsing between categories; the ability to save, import, and manage.
One proposal from @SaxonF can be a good starting point to make improvements to these area.
To highlight the tasks that could be started:
There's also a few other ideas that can be separated, like the re-addition of a most used / quick blocks as a top row. This is something we can introduce in the main inserter as well. It's also time we make it configurable so you can set 1-4 blocks customized for quick access.
I think this iteration should be focused on patterns and exclude the presence of a "blocks" category. We can try it in the zoomed out view being introduced for the site editor.
See also: #44496
This issue was updated Sep. 28.
Initial explorations
The text was updated successfully, but these errors were encountered: