-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns block with one-third/two-thirds split is labeled as "30/70" #41699
Comments
@WordPress/gutenberg-design there doesn't seem to be any indication on the PR that introduced these labels as to why It seems like rounding it to |
I definitely think that would be an improvement. If it were possible to fit 33.33/66.66 it would probably be best, since those are the exact values being used. But I think anything that reasonably conveys 1/3 and 2/3 is appropriate, whereas I do not read 30/70 as that at all. |
Here's what we're talking about for reference: My first question is: do we actually need to display these labels? The icons alone seem fairly clear to me, while the labels add noise and potential for confusion. Obviously it needs to be accessible, but I believe that is handled by the Edit: I just checked the original PR and see the labels were originally added to make things clearer, haha. For me, it's not very successful for the columns block, but I'm keen to hear thoughts from other designers. |
Well now that I look at the whole thing without being so singularly focused, I see the even thirds are labeled “33/33/33” so I think it makes sense to do “33/66” or “33/67” for the ones we’re talking about here. I see the appeal of removing the numbers altogether, but I think the icons alone may not be clear enough, since it’s a bit hard to discern the visual difference between the icons for 33/33/33 and 25/50/25. Also for accessibility we need to consider the labels regardless of whether they’re displayed for all users or not. |
Description
The description when hovering over the option says "Two columns; one-third, two-thirds split" and the actual percentages inserted with the block are 33.33% and 66.66%, but the icon for the option is labeled as "30/70". (Same goes for the reverse.)
Step-by-step reproduction instructions
Insert a Columns block and observe the labels under "Select a variation to start with."
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: