-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize widgets: Link Popover not visible in full (Entire toolbar not visible) #41739
Comments
I did my best to locate an existing issue with keywords like |
Closing this issue in favor of this one since that is already being looked at there. |
@Thelmachido From our testing, it looks like a core bug though, which is why I created this issue. Could we reopen this issue? |
Is it the Link popover that's cut off? The issue title says toolbar, but it's ok in the screenshots. edit: Seems so, I've updated the title. |
This issue also happens in other editors. I've worked on a fix for that - #42389. I expected this to also resolve the issue in the customizer, but it seems now the Link Popover ends up off the other side of the sidebar 😱 I think it should overflow the sidebar like the block toolbar does. |
These grotesque GUI flaws could be expected from a Microsoft-owned website, it's really sad to see them in Wordpress too. There's an alarming lack of testing of new features nowadays, who's rushing the WP team to add more and more features without proper testing? |
As mentioned in #43678 the following commit is the cause: 8b14921#diff-7895f8092f907d624abdbe647e2201f1cebe9198cd3fae6ba759b70a4c0bfef4 I believe this is because the |
This issue should have been fixed with the recent work on addressing popover regressions (#42770). Feel free to re-open in case the issue can still be replicated on latest |
I actually missed this comment — it looks like the issue that still needs to be fixed is that the link toolbar is cut off by the toolbar's edges. I'll look into it and report back |
Description
On a theme with block widgets, the toolbar on the widgets area of the Customizer is not visible in full. It gets cut in the middle, with half appearing outside of the display area.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: