Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: styles for textDecoration on nav links are too specific #42444

Open
mikachan opened this issue Jul 14, 2022 · 0 comments
Open

Navigation: styles for textDecoration on nav links are too specific #42444

mikachan opened this issue Jul 14, 2022 · 0 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@mikachan
Copy link
Member

Description

The following CSS for handling textDecoration on navigation block links is too specific:

.wp-block-navigation:where(:not([class*=has-text-decoration])) a

This prevents links inside the navigation block from being underlined by default. However, this should not take precedence if we set the global links to be underlined.

Step-by-step reproduction instructions

Add the following to a theme.json file, under styles.elements.link.typography:

"styles": {
	"elements": {
	        "link": {
		        "typography": {
			        "textDecoration": "underline"
		        }
	        }
	}
}

Screenshots, screen recording, code snippet

This is the CSS applied to a navigation link with the above theme.json settings:

image

Environment info

WP 6.0.1, latest GB trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@mikachan mikachan added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Block] Navigation Link Affects the Navigation Link Block labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant