Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 13.7.3 - Smaller editor font size for some themes #42902

Closed
masperber opened this issue Aug 2, 2022 · 3 comments · Fixed by #42906
Closed

Gutenberg 13.7.3 - Smaller editor font size for some themes #42902

masperber opened this issue Aug 2, 2022 · 3 comments · Fixed by #42906
Assignees
Labels
[Feature] Custom Editor Styles Functionality for adding custom editor styles [Type] Bug An existing feature does not function as intended

Comments

@masperber
Copy link

Description

In Gutenberg 13.7.x, the editor font size has been changed for some themes. (This does not affect font sizes on the live site.)

For example, in the Dara theme, the editor font size is now 16px, where it was previously 18px. It looks like the 18px size was previously being set by .editor-styles-wrapper in 13.6.0, but that isn't the case in 13.7.x. The editor also isn't showing the correct font any more.

This has not yet been reproduced in another theme.

Step-by-step reproduction instructions

  1. Create a site on WordPress 6.0.1 and Gutenberg 13.7.3 using Dara theme and all default font settings
  2. Editor font size is smaller in comparison to editor font size on Gutenber 13.6.0.

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.0.1 (WordPress.com)
Gutenberg 13.7.3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@dd32 dd32 added [Type] Bug An existing feature does not function as intended [Feature] Custom Editor Styles Functionality for adding custom editor styles labels Aug 3, 2022
@dd32
Copy link
Member

dd32 commented Aug 3, 2022

This has not yet been reproduced in another theme.

Just noting that I've confirmed this on Make.WordPress.org, as a change between Gutenberg 13.6.0 & 13.7.0.
As reported here: https://wordpress.slack.com/archives/C02QB8GMM/p1659448511556299

@andrewserong
Copy link
Contributor

andrewserong commented Aug 3, 2022

Thanks for reporting!

Looks like the styles that aren't being output are the default editor styles, which are defined here:

and then are flagged for output here:
: defaultEditorStyles;

As of #40875, the base layout styles are now being output as part of the global styles output, so I believe we might need an updated check here to determine whether or not the defaultEditorStyles should be output? Not sure if that's the only thing going on with this issue.

I'll do a bit more digging, thanks to @glendaviesnz for flagging that it was related to that PR!

@andrewserong
Copy link
Contributor

I think we can fix this on the PHP side when we output base layout styles for Classic themes. I've opened up a PR in #42906 with a potential fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Custom Editor Styles Functionality for adding custom editor styles [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants