Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Mobile "Close" icon misplaced #43523

Closed
beafialho opened this issue Aug 23, 2022 · 1 comment · Fixed by #43576
Closed

Navigation: Mobile "Close" icon misplaced #43523

beafialho opened this issue Aug 23, 2022 · 1 comment · Fixed by #43576
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@beafialho
Copy link

beafialho commented Aug 23, 2022

Description

It’s frustrating that the X button doesn’t sit in the same place as the hamburger icon. I'd expect it would sit on the same area.

Step-by-step reproduction instructions

  1. Create a navigation menu
  2. See the site on mobile
  3. Notice how the icons are misplaced

Screenshots, screen recording, code snippet

navanimation.mp4

Environment info

This happens with every theme and in the latest Gutenberg version.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jasmussen
Copy link
Contributor

I have a potential fix in #43576, that needs a sanity check. If we're able to land it, it will require a theme to do a few things in order for it to work:

  • The theme opts into root paddings (Core CSS support for root padding and alignfull blocks #42085), by adding "useRootPaddingAwareAlignments": true in theme.json under settings, and paddings to go with that either in global styles or under styles > spacing.
  • The Header template part contains a group that inherits layout, with navigation inside that.
  • The collapsing navigation block sits in the top right corner of the header, justified right.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 24, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants